ref(node): Streamline Prisma instrumentation (v6 and v7)#21819
Open
s1gr1d wants to merge 10 commits into
Open
Conversation
s1gr1d
requested review from
JPeer264,
andreiborza,
mydea and
nicohrubec
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
nicohrubec
reviewed
Jun 26, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
andreiborza
reviewed
Jun 29, 2026
Comment on lines
+90
to
92
| public getActiveContext(): Span | undefined { | ||
| return getActiveSpan(); | ||
| } |
Member
There was a problem hiding this comment.
This seems weird to me 😬 but I can't tell if it's ok or not. We'd need to investigate when exactly getActiveContext was called before and if it's fine receiving a span now?
Member
There was a problem hiding this comment.
from what I can tell this should be fine, the output of getActiveContext is only used by getTraceParent which we also control
| } | ||
|
|
||
| const context = options.context ?? _context.active(); | ||
| const parentSpan = options.context ?? getActiveSpan(); |
Member
There was a problem hiding this comment.
Also here, context being a span, is that right?
Member
There was a problem hiding this comment.
options.context was dead it seems, so I simplified this
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f769463. Configure here.
andreiborza
approved these changes
Jun 30, 2026
Comment on lines
+46
to
+47
| globalThisWithPrismaInstrumentation[GLOBAL_VERSIONED_INSTRUMENTATION_KEY] = undefined; | ||
| globalThisWithPrismaInstrumentation[GLOBAL_INSTRUMENTATION_KEY] = undefined; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the vendored Prisma instrumentation onto Sentry's span APIs (v6/v7):
spanStarthook into span creation in the instrumentation.startSpanManual/startInactiveSpanfrom@sentry/coreinstead of the OTel tracer in the vendored tracing helper.setTracerProvider/tracerProviderand unused contract types (EngineTrace,EngineTraceEvent,LogLevel).v5 cleanup will be done in a followup.
Part of #20744
Closes #21820